Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Always resolve dynamic types in schema #20406

Merged
merged 3 commits into from
Dec 23, 2024
Merged

feat: Always resolve dynamic types in schema #20406

merged 3 commits into from
Dec 23, 2024

Conversation

ritchie46
Copy link
Member

Always ensure dynamic types are materialized in schema as that is what will be produced.

Also fixes #20355

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 22, 2024
Copy link

codecov bot commented Dec 22, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes missing coverage. Please review.

Project coverage is 78.98%. Comparing base (68eec85) to head (32936fc).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 5 Missing ⚠️
crates/polars-core/src/datatypes/dtype.rs 92.85% 1 Missing ⚠️
crates/polars-expr/src/reduce/convert.rs 0.00% 1 Missing ⚠️
...ates/polars-plan/src/plans/conversion/dsl_to_ir.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20406      +/-   ##
==========================================
+ Coverage   78.97%   78.98%   +0.01%     
==========================================
  Files        1562     1562              
  Lines      220078   220111      +33     
  Branches     2480     2486       +6     
==========================================
+ Hits       173802   173862      +60     
+ Misses      45705    45676      -29     
- Partials      571      573       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit f242871 into main Dec 23, 2024
26 checks passed
@ritchie46 ritchie46 deleted the resolve branch December 23, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

concat + sink_parquet creates corrupt file instead of raising ShapeError
1 participant