Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(python): Fix plotting f-strings and docstrings #20399

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

hamdanal
Copy link
Contributor

@hamdanal hamdanal commented Dec 21, 2024

  • Add missing f prefixes for f-strings
  • Add missing line in docstring of DataFrame.plot.line
  • Fix typo in docstring of Series.plot.line examples section

Closes #18475

@github-actions github-actions bot added fix Bug fix python Related to Python Polars labels Dec 21, 2024
Copy link
Collaborator

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @hamdanal !

@ritchie46 ritchie46 merged commit 0955b9a into pola-rs:main Dec 21, 2024
15 checks passed
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.95%. Comparing base (dbd2c5f) to head (a94eb93).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
py-polars/polars/series/plotting.py 0.00% 2 Missing ⚠️
py-polars/polars/dataframe/plotting.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20399   +/-   ##
=======================================
  Coverage   78.95%   78.95%           
=======================================
  Files        1561     1561           
  Lines      219881   219881           
  Branches     2471     2471           
=======================================
  Hits       173614   173614           
  Misses      45699    45699           
  Partials      568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamdanal hamdanal deleted the plotting-fix branch December 21, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attribute Error message not printing the attr that's missing
3 participants