Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix decimal arithmetic schema #20398

Merged
merged 2 commits into from
Dec 21, 2024
Merged

fix: Fix decimal arithmetic schema #20398

merged 2 commits into from
Dec 21, 2024

Conversation

ritchie46
Copy link
Member

fixes #20367

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 21, 2024
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes missing coverage. Please review.

Project coverage is 78.96%. Comparing base (dbd2c5f) to head (a95f184).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-plan/src/plans/aexpr/schema.rs 83.33% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20398   +/-   ##
=======================================
  Coverage   78.95%   78.96%           
=======================================
  Files        1561     1561           
  Lines      219881   219908   +27     
  Branches     2471     2471           
=======================================
+ Hits       173614   173642   +28     
+ Misses      45699    45698    -1     
  Partials      568      568           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 234810d into main Dec 21, 2024
24 checks passed
@ritchie46 ritchie46 deleted the decimal branch December 21, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Computed schema for lazy decimal operations is incorrect
1 participant