-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Order observability optimizations #20396
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20396 +/- ##
==========================================
+ Coverage 78.95% 78.96% +0.01%
==========================================
Files 1561 1562 +1
Lines 219931 220076 +145
Branches 2480 2480
==========================================
+ Hits 173643 173789 +146
+ Misses 45717 45716 -1
Partials 571 571 ☔ View full report in Codecov by Sentry. |
Not in front of my computer so I can’t test an example, is groupby always faster than sort.groupby eg in case of groupby a high cardinality float column where the values might be all unique? |
An operation doesn't have to maintain_order if it isn't observed. E.g.
concat().sort()
could do an unordered union for instance..sort().groupby().sum()
can remove the sort, etc.