Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove unused IR::Reduce node #20392

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Dec 20, 2024

This was intended as a special case for select which only returns a single row but physical planners can already inspect the expressions in a select to determine whether this is the case regardless.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Dec 20, 2024
@ritchie46 ritchie46 merged commit 6965ac7 into main Dec 20, 2024
22 checks passed
@ritchie46 ritchie46 deleted the remove-ir-reduce-node branch December 20, 2024 17:36
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.94%. Comparing base (2c9e503) to head (813995a).
Report is 20 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20392      +/-   ##
==========================================
+ Coverage   78.91%   78.94%   +0.03%     
==========================================
  Files        1567     1560       -7     
  Lines      219928   219635     -293     
  Branches     2465     2471       +6     
==========================================
- Hits       173549   173389     -160     
+ Misses      45811    45678     -133     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants