Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Propagate nulls for float methods on all numeric types #20386

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

lukemanley
Copy link
Contributor

The use case isn't obvious, but the float-specific methods currently work on all numeric types. The current implementation only propagates nulls for float types. This makes null propagation consistent across all types.

@github-actions github-actions bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Dec 20, 2024
@ritchie46
Copy link
Member

Good observation.

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.91%. Comparing base (5d2d550) to head (9803e45).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20386      +/-   ##
==========================================
- Coverage   79.14%   78.91%   -0.23%     
==========================================
  Files        1566     1567       +1     
  Lines      219231   219928     +697     
  Branches     2465     2465              
==========================================
+ Hits       173503   173554      +51     
- Misses      45160    45806     +646     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit 2c9e503 into pola-rs:main Dec 20, 2024
26 checks passed
@lukemanley lukemanley deleted the float-method-null-propagation branch December 25, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants