-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add env var to ignore file cache allocate error #20356
Merged
ritchie46
merged 6 commits into
pola-rs:main
from
nameexhaustion:file-cache-no-allocate
Dec 19, 2024
Merged
feat: Add env var to ignore file cache allocate error #20356
ritchie46
merged 6 commits into
pola-rs:main
from
nameexhaustion:file-cache-no-allocate
Dec 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
New feature or an improvement of an existing feature
python
Related to Python Polars
rust
Related to Rust Polars
labels
Dec 19, 2024
nameexhaustion
changed the title
feat: Don't pre-allocate in file cache download
fix: Don't pre-allocate in file cache download
Dec 19, 2024
nameexhaustion
removed
the
enhancement
New feature or an improvement of an existing feature
label
Dec 19, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20356 +/- ##
==========================================
- Coverage 79.13% 79.12% -0.01%
==========================================
Files 1572 1572
Lines 219839 219859 +20
Branches 2462 2462
==========================================
- Hits 173970 173966 -4
- Misses 45301 45325 +24
Partials 568 568 ☔ View full report in Codecov by Sentry. |
nameexhaustion
requested review from
ritchie46,
orlp and
c-peters
as code owners
December 19, 2024 06:02
nameexhaustion
changed the title
fix: Don't pre-allocate in file cache download
feat: Add env var to ignore file cache allocate error
Dec 19, 2024
github-actions
bot
added
the
enhancement
New feature or an improvement of an existing feature
label
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
accepted
Ready for implementation
enhancement
New feature or an improvement of an existing feature
fix
Bug fix
python
Related to Python Polars
rust
Related to Rust Polars
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a flag
POLARS_IGNORE_FILE_CACHE_ALLOCATE_ERROR
to ignore any allocation errors from thestd::fs::File::allocate
call. May help with:scan_csv()
in container fails with disk space error (e.g. AWS lambda, or container) #17946There is a chance this allocate is incorrectly failing. I've also adjusted the print to include the IO error itself.