Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add env var to ignore file cache allocate error #20356

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Dec 19, 2024

Adds a flag POLARS_IGNORE_FILE_CACHE_ALLOCATE_ERROR to ignore any allocation errors from the std::fs::File::allocate call. May help with:

There is a chance this allocate is incorrectly failing. I've also adjusted the print to include the IO error itself.

@github-actions github-actions bot added enhancement New feature or an improvement of an existing feature python Related to Python Polars rust Related to Rust Polars labels Dec 19, 2024
@nameexhaustion nameexhaustion changed the title feat: Don't pre-allocate in file cache download fix: Don't pre-allocate in file cache download Dec 19, 2024
@nameexhaustion nameexhaustion removed the enhancement New feature or an improvement of an existing feature label Dec 19, 2024
@github-actions github-actions bot added the fix Bug fix label Dec 19, 2024
Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 79.12%. Comparing base (6e4d717) to head (99d57b6).
Report is 32 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-io/src/file_cache/entry.rs 41.66% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #20356      +/-   ##
==========================================
- Coverage   79.13%   79.12%   -0.01%     
==========================================
  Files        1572     1572              
  Lines      219839   219859      +20     
  Branches     2462     2462              
==========================================
- Hits       173970   173966       -4     
- Misses      45301    45325      +24     
  Partials      568      568              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review December 19, 2024 06:02
@nameexhaustion nameexhaustion marked this pull request as draft December 19, 2024 07:07
@nameexhaustion nameexhaustion changed the title fix: Don't pre-allocate in file cache download feat: Add env var to ignore file cache allocate error Dec 19, 2024
@github-actions github-actions bot added the enhancement New feature or an improvement of an existing feature label Dec 19, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review December 19, 2024 07:52
@nameexhaustion nameexhaustion marked this pull request as draft December 19, 2024 07:54
@nameexhaustion nameexhaustion marked this pull request as ready for review December 19, 2024 08:38
@ritchie46 ritchie46 merged commit b1e5b1d into pola-rs:main Dec 19, 2024
20 checks passed
@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation enhancement New feature or an improvement of an existing feature fix Bug fix python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants