Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Use Column in Row Encoding #20312

Merged
merged 2 commits into from
Dec 16, 2024

Conversation

coastalwhite
Copy link
Collaborator

Now we can use Column for unordered Row-Encoding and the python interface now calls the standard functions.

Now we can use `Column` for unordered Row-Encoding and the python interface now
calls the standard functions.
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 3 lines in your changes missing coverage. Please review.

Project coverage is 79.62%. Comparing base (ff95fad) to head (a9af910).
Report is 46 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-expr/src/hash_keys.rs 0.00% 2 Missing ⚠️
crates/polars-ops/src/frame/join/mod.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #20312   +/-   ##
=======================================
  Coverage   79.61%   79.62%           
=======================================
  Files        1567     1567           
  Lines      218453   218428   -25     
  Branches     2462     2462           
=======================================
- Hits       173921   173916    -5     
+ Misses      43965    43945   -20     
  Partials      567      567           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ritchie46 ritchie46 merged commit ad38583 into pola-rs:main Dec 16, 2024
20 checks passed
@coastalwhite coastalwhite deleted the refactor/re-simplification branch December 16, 2024 13:47
@c-peters c-peters added the accepted Ready for implementation label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants