-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add cat.starts_with
/cat.ends_with
#20257
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20257 +/- ##
==========================================
- Coverage 79.65% 79.10% -0.56%
==========================================
Files 1565 1572 +7
Lines 218281 220015 +1734
Branches 2475 2467 -8
==========================================
+ Hits 173878 174046 +168
- Misses 43836 45401 +1565
- Partials 567 568 +1 ☔ View full report in Codecov by Sentry. |
I am really not sure about the cast. Will have to think about this for a bit. |
We could simply disallow nonscalar expression inputs. Having nonscalar expression inputs does lean towards the "categoricals as string optimizations" (and in this case, it wouldn't even be an optimization) which I know is not their intended behavior. So--I propose only allowing scalar inputs here. This would completely remove the slow path. What do you think? |
@Ritchie I've removed the slow path, and switched to only allow |
Follow up to #20211.
Edit 2024-12-18: expression implementation has been removed, along with the slow path.
cat.starts_with
andcat.ends_with
now requirestr
inputs and do not except expressions.