-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add example and tests for pl.concat()
with Expr
input
#19836
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19836 +/- ##
==========================================
+ Coverage 79.33% 79.50% +0.16%
==========================================
Files 1548 1556 +8
Lines 214245 216530 +2285
Branches 2460 2457 -3
==========================================
+ Hits 169968 172145 +2177
- Misses 43719 43827 +108
Partials 558 558 ☔ View full report in Codecov by Sentry. |
py-polars/polars/functions/eager.py
Outdated
how : {'vertical', 'vertical_relaxed', 'diagonal', 'diagonal_relaxed', 'horizontal', 'align'} | ||
Series only support the `vertical` strategy. | ||
This is not used when items are Expr. Series only support the `vertical` strategy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think vertical
should be checked for Expr as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not used when items are Expr. Series only support the `vertical` strategy. | |
Series and Expr only support the `vertical` strategy. |
Test failures only appear with the new streaming engine but I have no idea why. Should I remove the new test? |
I suppose you can skip tests with |
Thanks, it passes now |
Ran into issues when |
If you're new to Git, I recommend that you don't try to rebase. |
Not new, but I never use that (and when I do I rely on the github interface). I see it's the norm here, which is why I tried |
There would have been no need to close the PR if the branch had been reset to the state it was in before the rebase attempt was made. |
Fixes #19813