Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add example and tests for pl.concat() with Expr input #19836

Closed
wants to merge 86 commits into from

Conversation

etiennebacher
Copy link
Contributor

Fixes #19813

@github-actions github-actions bot added documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars labels Nov 17, 2024
Copy link

codecov bot commented Nov 17, 2024

Codecov Report

Attention: Patch coverage is 85.34075% with 527 lines in your changes missing coverage. Please review.

Project coverage is 79.50%. Comparing base (6ccb187) to head (1328485).
Report is 69 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-row/src/encode.rs 81.12% 124 Missing ⚠️
...tream/src/nodes/parquet_source/row_group_decode.rs 0.00% 75 Missing ⚠️
...rates/polars-compute/src/horizontal_flatten/mod.rs 60.28% 56 Missing ⚠️
...lars-core/src/series/arithmetic/fixed_size_list.rs 92.49% 41 Missing ⚠️
crates/polars-ops/src/series/ops/round.rs 63.20% 39 Missing ⚠️
crates/polars-row/src/decode.rs 85.96% 24 Missing ⚠️
crates/polars-row/src/variable.rs 85.48% 18 Missing ⚠️
crates/polars-schema/src/schema.rs 55.88% 15 Missing ⚠️
.../polars-ops/src/chunked_array/strings/find_many.rs 73.07% 14 Missing ⚠️
crates/polars-row/src/row.rs 67.74% 10 Missing ⚠️
... and 32 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #19836      +/-   ##
==========================================
+ Coverage   79.33%   79.50%   +0.16%     
==========================================
  Files        1548     1556       +8     
  Lines      214245   216530    +2285     
  Branches     2460     2457       -3     
==========================================
+ Hits       169968   172145    +2177     
- Misses      43719    43827     +108     
  Partials      558      558              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

how : {'vertical', 'vertical_relaxed', 'diagonal', 'diagonal_relaxed', 'horizontal', 'align'}
Series only support the `vertical` strategy.
This is not used when items are Expr. Series only support the `vertical` strategy.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think vertical should be checked for Expr as well.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This is not used when items are Expr. Series only support the `vertical` strategy.
Series and Expr only support the `vertical` strategy.

@etiennebacher
Copy link
Contributor Author

Test failures only appear with the new streaming engine but I have no idea why. Should I remove the new test?

ritchie46
ritchie46 previously approved these changes Nov 19, 2024
@eitsupi
Copy link
Contributor

eitsupi commented Nov 27, 2024

I suppose you can skip tests with @pytest.mark.may_fail_auto_streaming for now.

@etiennebacher
Copy link
Contributor Author

Thanks, it passes now

@etiennebacher etiennebacher marked this pull request as ready for review November 27, 2024 13:23
@etiennebacher
Copy link
Contributor Author

etiennebacher commented Nov 27, 2024

Ran into issues when rebasing trying to rebase, will open a new one

@eitsupi
Copy link
Contributor

eitsupi commented Nov 27, 2024

If you're new to Git, I recommend that you don't try to rebase.

@etiennebacher
Copy link
Contributor Author

Not new, but I never use that (and when I do I rely on the github interface). I see it's the norm here, which is why I tried

@eitsupi
Copy link
Contributor

eitsupi commented Nov 27, 2024

There would have been no need to close the PR if the branch had been reset to the state it was in before the rebase attempt was made.

@etiennebacher etiennebacher deleted the concat-expr branch November 28, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should pl.concat() accept Expr input?