Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Fix new-streaming test_parquet::test_complex_types #18829

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

nameexhaustion
Copy link
Collaborator

Before

df.with_columns(s.alias("b")) = shape: (4, 2)
┌───────────────┬────────────────────┐
│ a             ┆ b                  │
│ ---           ┆ ---                │
│ array[i64, 3] ┆ array[i64, 3]      │
╞═══════════════╪════════════════════╡
│ null          ┆ null               │
│ [1, null, 3]  ┆ [1, null, 3]       │
│ null          ┆ [null, null, null] │
│ [1, 2, null]  ┆ [1, 2, null]       │
└───────────────┴────────────────────┘

After

df.with_columns(s.alias("b")) = shape: (4, 2)
┌───────────────┬───────────────┐
│ ab             │
│ ------           │
│ array[i64, 3] ┆ array[i64, 3] │
╞═══════════════╪═══════════════╡
│ nullnull          │
│ [1, null, 3]  ┆ [1, null, 3]  │
│ nullnull          │
│ [1, 2, null]  ┆ [1, 2, null]  │
└───────────────┴───────────────┘

@nameexhaustion nameexhaustion changed the title refactor(rust): Fix new-streaming 'test_parquet::test_complex_types refactor(rust): Fix new-streaming test_parquet::test_complex_types Sep 20, 2024
@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 20, 2024
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (506f927) to head (6b73ded).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18829      +/-   ##
==========================================
- Coverage   79.86%   79.86%   -0.01%     
==========================================
  Files        1518     1518              
  Lines      205637   205636       -1     
  Branches     2893     2893              
==========================================
- Hits       164233   164224       -9     
- Misses      40856    40864       +8     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 20, 2024 11:30
@ritchie46 ritchie46 merged commit b6263e2 into pola-rs:main Sep 20, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 23, 2024
@nameexhaustion nameexhaustion deleted the bitmap-fix branch September 27, 2024 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants