Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Ensure fallback node gets correct length df even if no columns selected #18772

Merged
merged 1 commit into from
Sep 16, 2024

Conversation

orlp
Copy link
Collaborator

@orlp orlp commented Sep 16, 2024

This fixed a bug for example in arg_sort_by where you select pl.int_range(0, pl.len()) which (currently) goes to the fallback, but doesn't actually select a column.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 79.84%. Comparing base (a53bf03) to head (45dac76).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
...ates/polars-stream/src/physical_plan/lower_expr.rs 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18772      +/-   ##
==========================================
- Coverage   79.86%   79.84%   -0.02%     
==========================================
  Files        1517     1518       +1     
  Lines      205533   205576      +43     
  Branches     2892     2892              
==========================================
+ Hits       164142   164144       +2     
- Misses      40843    40884      +41     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orlp orlp enabled auto-merge (squash) September 16, 2024 14:29
@orlp orlp disabled auto-merge September 16, 2024 14:29
@orlp orlp merged commit 6561eba into pola-rs:main Sep 16, 2024
23 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants