Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(rust): Remove short-lived / non-CPU bound task spawns on async executor in new-streaming #18764

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

nameexhaustion
Copy link
Collaborator

No description provided.

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Sep 16, 2024
Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 79.86%. Comparing base (4894e24) to head (88ecaf4).
Report is 39 commits behind head on main.

Files with missing lines Patch % Lines
...tes/polars-stream/src/nodes/parquet_source/init.rs 0.00% 12 Missing ⚠️
...m/src/nodes/parquet_source/row_group_data_fetch.rs 0.00% 5 Missing ⚠️
...ates/polars-stream/src/nodes/parquet_source/mod.rs 0.00% 3 Missing ⚠️
...tream/src/nodes/parquet_source/row_group_decode.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #18764      +/-   ##
==========================================
+ Coverage   79.85%   79.86%   +0.01%     
==========================================
  Files        1517     1517              
  Lines      205530   205516      -14     
  Branches     2892     2892              
==========================================
+ Hits       164119   164132      +13     
+ Misses      40863    40836      -27     
  Partials      548      548              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review September 16, 2024 11:47
@ritchie46 ritchie46 merged commit d11c5c3 into pola-rs:main Sep 18, 2024
21 checks passed
@c-peters c-peters added the accepted Ready for implementation label Sep 23, 2024
@nameexhaustion nameexhaustion deleted the pqs-spawn branch September 27, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted Ready for implementation internal An internal refactor or improvement rust Related to Rust Polars
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants