Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Gen 1 and Gen 2 ball flairs with dex images #669

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Replace Gen 1 and Gen 2 ball flairs with dex images #669

wants to merge 2 commits into from

Conversation

SnowPhoenix
Copy link
Contributor

No description provided.

@SnowPhoenix SnowPhoenix mentioned this pull request May 1, 2021
Closed
Raia
Raia reviewed May 22, 2021
View reviewed changes
Copy link
Member

@Raia Raia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but maybe we can consider changing the gen 3 dex class to gen3 for mod usability. It'd require that we schedule out a quick maintenance to run the flair change script on the sub though.

api/services/Flairs.js
const flairNames = {
"pokemontrades": {
"default" : "Gen 1 Dex",
"gen2" : "Gen 3 Dex",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll probably want to do a flair migration and change the css class name from gen2 to gen3 for mod usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raia Raia Raia left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SnowPhoenix @Raia