Use fixed width data type in crc32 calculation #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
uint_least32_t isn't a fixed width type, so this isn't the correct necessarily (uint32_t is the actual fixed width type that uint_least32_t usually corresponds to). I'm fairly sure however all you actually need to fix the issue is to have a & 0xFFFFFFFF to the ~ usages if anything. |
CasualPokePlayer
added a commit
that referenced
this pull request
Feb 1, 2024
|
Should be fixed in 809ba4f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to differences in compilers, the crc32 calculation in the no-libz-path may output different results.
The cause for this phenomenon, is that the data type
unsigned longmay be of different size depending on the compiler. An example of this occuring, and its consequences can be seen here: https://godbolt.org/z/x1bcGW9n6This PR attempts to fix the issue by using a fixed 32-bit width data type instead.