Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cancel crash in latest version of asi #405

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

grittymindy
Copy link

The crash happens if you cancel a request that satisfies:

  1. currently waiting in queue, not been started yet
  2. there is valid cached data for this request in downloadCache

The fix is similar to jogu@887fcad. That's, avoid calling markAsFinished unless we're in progress.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant