Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing very obvious wrong behaviour when cleaning up the blocks that could cause many different-hard to figure out crashes #345

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixing very obvious wrong behaviour when cleaning up the blocks that could cause many different-hard to figure out crashes #345

wants to merge 1 commit into from

Commits on Oct 11, 2012

  1. Fixing very obvious wrong behaviour when cleaning up the blocks. 

    There was a code added to make sure that the blocks were deallocated on the main thread, and it was wrong (it was over-releasing an NSMutableArray). Somebody fixed it by removing the second release, which is the wrong fix. There's an obvious code smell seeing how there's a performSelector: to a method that does nothing....
This is one of the thounsands of wrong things in ASIHTTPRequest, specially in memory management, I strongly recomment to all the folks out there that you migrate to AFNetworking, but I'm pushing the pull request in case somebody is getting crashes from this.
    @JaviSoto
    JaviSoto committed Oct 11, 2012
    Configuration menu
    Copy the full SHA
    ee3edc0 View commit details
    Browse the repository at this point in the history