Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #840: Grpc build emit package when package is empty #841

Merged
merged 2 commits into from
Jul 16, 2024
Merged

Fix #840: Grpc build emit package when package is empty #841

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86e396a
grpc build: emit grpc package when package is empty
4t145 Jul 3, 2024
d85dc07
emit package name when package name is empty
4t145 Jul 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion poem-grpc-build/src/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ pub(crate) fn generate(config: &GrpcConfig, service: &Service, buf: &mut String)
let name = format_ident!("{}", method.name);
let input_type = syn::parse_str::<Type>(&method.input_type).unwrap();
let output_type = syn::parse_str::<Type>(&method.output_type).unwrap();
let path = if !config.emit_package {
let path = if !config.emit_package && !service.package.is_empty() {
format!(
"/{}.{}/{}",
service.package, service.proto_name, method.proto_name
Expand Down
2 changes: 1 addition & 1 deletion poem-grpc-build/src/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ pub(crate) fn generate(config: &GrpcConfig, service: &Service, buf: &mut String)
})
.collect::<Vec<_>>();
let crate_name = get_crate_name(config.internal);
let service_name = if !config.emit_package {
let service_name = if !config.emit_package && !service.package.is_empty() {
format!("{}.{}", service.package, service.proto_name)
} else {
service.proto_name.clone()
Expand Down
Loading