Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add is_empty() method to validate numeric pick values #5776

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add is_empty() method to validate numeric pick values #5776

wants to merge 2 commits into from

Conversation

JoryHogeveen
Copy link
Member

@JoryHogeveen JoryHogeveen commented Jul 14, 2020 •
edited
Loading

0 could be valid for weekdays and custom simple relationships.

Fixes: #1854

  • NEEDS TESTING WITH [if] TAGS
    • Fixes issues with weekdays: Sunday is stored as 0 so in fact should be a valid, non-empty, value.
    • Fixes issues where users might add a key 0 for a valid value.
    • Might cause bugs where users store a key 0 for empty values (No for example).

Changelog text for these changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows has proper inline documentation.
  • My code includes PHP Unit Tests (if applicable)

@JoryHogeveen
Add is_empty() method to validate numeric pick values
114c3a4 
0 could be valid for weekdays and custom simple relationships.
@JoryHogeveen JoryHogeveen self-assigned this Jul 14, 2020
@JoryHogeveen JoryHogeveen added Focus: Back Compat Status: PR > Pending Code Review PR is pending code review by core developers Status: PR > QA pending QA needs to be done Type: Bug Type: Enhancement Enhancements to features that already exist, but are not major additions labels Jul 14, 2020
@JoryHogeveen JoryHogeveen added this to the Pods 2.7.22 milestone Jul 14, 2020
@JoryHogeveen JoryHogeveen linked an issue Jul 14, 2020 that may be closed by this pull request
Supposedly empty fields shows values in pods manage page. #1854
Open
tr1b0t
tr1b0t reviewed Jul 14, 2020
View reviewed changes
Copy link

@tr1b0t tr1b0t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 1 error(s)

classes/fields/pick.php Show resolved Hide resolved
@sc0ttkclark sc0ttkclark changed the base branch from 2.x to release/2.7.22 July 15, 2020 14:55
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.22, Pods 2.7.23 Aug 13, 2020
@sc0ttkclark sc0ttkclark changed the base branch from release/2.7.22 to main August 13, 2020 18:02
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.23, Pods 2.7.24 Oct 15, 2020
@JoryHogeveen JoryHogeveen modified the milestones: Pods 2.7.24, Pods 2.7.25 Nov 5, 2020
sc0ttkclark
sc0ttkclark previously approved these changes Dec 17, 2020
View reviewed changes
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers labels Dec 17, 2020
@sc0ttkclark sc0ttkclark changed the base branch from main to release/2.7.25 December 17, 2020 15:04
@sc0ttkclark sc0ttkclark dismissed their stale review December 17, 2020 15:04

The base branch was changed.

@JoryHogeveen JoryHogeveen modified the milestones: Pods 2.7.25, Pods 2.7.26 Dec 18, 2020
Base automatically changed from release/2.7.25 to main December 22, 2020 05:17
@sc0ttkclark sc0ttkclark removed this from the Pods 2.7.26 milestone Jan 8, 2021
@sc0ttkclark sc0ttkclark added this to the Pods 2.7.27 milestone Jan 8, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.27, Pods 2.7.28 Apr 16, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.28, Pods 2.7.29 May 19, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.29, Pods 2.7.30 Aug 4, 2021
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.7.30, Pods 2.7.31 Aug 12, 2021
@sc0ttkclark sc0ttkclark marked this pull request as draft July 25, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tr1b0t tr1b0t tr1b0t left review comments

@sc0ttkclark sc0ttkclark sc0ttkclark left review comments

@jimtrue jimtrue Awaiting requested review from jimtrue

At least 1 approving review is required to merge this pull request.

Assignees

@JoryHogeveen JoryHogeveen

Labels
Focus: Back Compat Status: PR > QA pending QA needs to be done Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Bug Type: Enhancement Enhancements to features that already exist, but are not major additions
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

Supposedly empty fields shows values in pods manage page.
3 participants
@JoryHogeveen @sc0ttkclark @tr1b0t