Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/empty dataset #283

Merged
merged 25 commits into from
Jul 29, 2024
Merged

Feature/empty dataset #283

merged 25 commits into from
Jul 29, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Jul 29, 2024 •
edited
Loading

Description

  • Allow l2ss harmony to handle the return of an empty dataset

Overview of work done

  • Modify so that when we create an empty dataset the dtype is the same
  • If the returning dataset file is empty then don't return the bounding box for harmony stac

Overview of verification done

  • Tested in local harmony and local l2ss subsetting

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008
update get time functions
6f85237
@sliu008
update to fix pylint flake8
93432d4
@sliu008
update project dependencies
8499389
@sliu008
fix tests
db9a3a8
@sliu008
update libraries for snyk
2598001
@sliu008
poetry update
804f131
@sliu008
update pytoml
ee1d2a4
@sliu008
update test retry time
72f5caa
@sliu008
add harmony deployment into github actions
0e6957b
@sliu008
update harmony deployment script
49b8881
@sliu008
update pytoml version to develop
01b0f3f
@sliu008
update tests delays
0abd69a
@sliu008
fix harmony deploy url
e9dd079
@sliu008
removed debug print statement
11c67fb
@sliu008
update copy of empty data, and check bounds for empty datasets
fc60192
@sliu008
Merge branch 'develop' into feature/empty_dataset
086e9fb
@sliu008
update tests for empty datasets
20e0eee
@sliu008
update to fix temporal subsetting
e0917a4
@sliu008
fix ghrsst dataset temporal subsetting
1a25de3
@sliu008
add try except for getting long name
52dc007
@sliu008
optimize mask and scale code
9b1d9c1
@sliu008
optimize code
89c9d0c
@sliu008
poetry update
a566251
@sliu008
merge in release 2.11.0
e2c050a
jamesfwood
jamesfwood approved these changes Jul 29, 2024
View reviewed changes
Copy link
Collaborator

@jamesfwood jamesfwood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge when you're ready

@sliu008 sliu008 merged commit f418d5a into release/2.11.0 Jul 29, 2024
2 checks passed
@sliu008 sliu008 deleted the feature/empty_dataset branch July 29, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesfwood jamesfwood jamesfwood approved these changes

@frankinspace frankinspace frankinspace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sliu008 @jamesfwood @frankinspace