Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix temporal subsetting ghrsst #280

Merged
merged 4 commits into from
Jul 18, 2024

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Jul 15, 2024

Description

  • Sometime when accessing sst_dtime variable in some collection we get an exception _scale_offset_decoding\r\n data *= scale_factor\r\nnumpy.core._exceptions._UFuncOutputCastingError: Cannot cast ufunc 'multiply' output from dtype('float64') to dtype('int64') with casting rule 'same_kind'\r\n`. Track down the problem when we set the mask_and_scale to true when opening the file.

Overview of work done

  • Add a new function to test the ability to use access the sst_dtime variable to determine if we should use mask_and_scale

Overview of verification done

  • Tested temporal subsetting locally

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@sliu008 sliu008 marked this pull request as ready for review July 15, 2024 23:30
Copy link
Member

@frankinspace frankinspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add changelog entry

@frankinspace frankinspace merged commit d6f20b2 into release/2.11.0 Jul 18, 2024
1 check passed
@frankinspace frankinspace deleted the feature/fix_temporal_subsetting_ghrsst branch July 18, 2024 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants