Feature/issue 172 #193
Merged
Feature/issue 172 #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Github Issue: #172 (replace NUM with Github issue number)
Description
After some debugging, it seems like there is an issue with the L2SS service when ordering from Earthdata Search with a shapefile for subsetting. We have confirmed we are successfully passing a valid shapefile. When the request is made to Harmony we receive the following error:
WorkItem [16079488] failed with error: podaac/l2ss-py:2.4.0: Service request failed with an unknown error
Jira: PCESA-2733
Overview of work done
Fix parameter passing into subset function from shapefile_path to shapefile
Overview of verification done
Looked into error log and see error is wrong parameter passed into function, don't have shapefile to test with harmony and earthdata search, will test in UAT
Overview of integration done
Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request