Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 119 #179

Closed
wants to merge 52 commits into from
Closed

Feature/issue 119 #179

wants to merge 52 commits into from

Conversation

nlenssen2013
Copy link
Collaborator

Github Issue: #119

Description

Specific code addition for GPM files. Need to loop through the variables to change the dimensions from phony dimensions
to what the dimensions are in the attributes.

Overview of work done

Loop through each variable, check if it's a variable that might be deleted if a variable subset is asked from the user. Get the DimensionName in the attributes, if the DimensionName is unique, create a new dimension and set the dimensions of the variables to the true names.

Overview of verification done

Test written to check that none of the variables have a "phony" dimension.

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • [x ] Linted
  • [x ] Updated unit tests
  • [x ] Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@nlenssen2013 nlenssen2013 deleted the feature/issue-119 branch July 28, 2023 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant