Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue/hitide UI 44 - footprints and previews not correctly removing from map #61

Merged
merged 13 commits into from
Apr 1, 2024
Merged

Issue/hitide UI 44 - footprints and previews not correctly removing from map #61

merged 13 commits into from
Apr 1, 2024

Conversation

jbyrne6
Copy link
Contributor

@jbyrne6 jbyrne6 commented Mar 28, 2024

Fixes

  • handled case where the "Granule-Id" was not being added to an object in the gridStore after certain cases like sorting the grid which caused the granule not to be deleted off the map.

@jbyrne6 jbyrne6 added the bug Something isn't working label Mar 28, 2024
@jbyrne6 jbyrne6 self-assigned this Mar 28, 2024
@jbyrne6 jbyrne6 linked an issue Mar 28, 2024 that may be closed by this pull request
Footprints and Thumbnail images remain on map in UI after the Footprint and Thumbnail image icons were deselected #44
Closed
@jamesfwood jamesfwood merged commit e9ed576 into develop Apr 1, 2024
3 checks passed
@jamesfwood jamesfwood deleted the issue/hitide-ui-44 branch April 1, 2024 19:57
davidcolemanjpl
davidcolemanjpl reviewed Apr 1, 2024
View reviewed changes
Copy link

@davidcolemanjpl davidcolemanjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear to be okay

@jbyrne6 jbyrne6 restored the issue/hitide-ui-44 branch April 1, 2024 21:11
@jbyrne6 jbyrne6 deleted the issue/hitide-ui-44 branch April 1, 2024 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidcolemanjpl davidcolemanjpl davidcolemanjpl left review comments

@sliu008 sliu008 sliu008 approved these changes

@jamesfwood jamesfwood jamesfwood approved these changes

Assignees

@jbyrne6 jbyrne6

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
4 participants
@jbyrne6 @jamesfwood @davidcolemanjpl @sliu008