issue/161: Fix bug where --subset flag fails with data subscriber #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skorper
requested review from
jasonmlkang,
yenes56,
voxparcxls,
hkryeung and
phoeberepo
|
@jasonmlkang @yenes56 @hkryeung @voxparcxls @phoeberepo Can someone review this PR? I want to get this patch out ASAP. Thanks so much! |
phoeberepo
approved these changes
Mar 7, 2024
skorper
added a commit
that referenced
this pull request
Mar 20, 2024
* initial implementaiton of subset code * added tests, more updates * removed skip_errors (not implemented yet) * Upgrade to harmony-py 0.4.9 * subsetting capability initial commit * update spacing * Update docs * update poetry lock * upgrade to poetry 1.5.1 (latest) * fix failing checksum test * fixed regression test issues * bump poetry version in second gh action file * Update poetry version to fix build issue * bump poetry version * bump poetry version * bump version to 1.15.0 * bump version to 1.15.0 * add unreleased section to changelog * issue/161: Fix bug where --subset flag fails with data subscriber (#162) * fix bug where the subset flag fails for subscriber * move arg validation to correct spot * bump version * bump version * Issue/164: Upgrade harmony-py to avoid 413 request entity too large issue (#165) * bump harmony-py version to 0.4.12 * /version 1.15.1-alpha.2 --------- Co-authored-by: mike-gangl <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #161
This fixes the above issue and allows the data subscriber to run as expected with the --subset flag enabled.
Testing
Able to run the subscriber with the --subset flag present:
But cannot run the downloader with both --subset and --cycles:
➜ poetry run python3 subscriber/podaac_data_downloader.py -c SWOT_L2_NALT_GDR_SSHA_2.0 -d .data/ -e .nc --cycle 474 --subset [2024-03-04 14:31:30,886] {podaac_data_downloader.py:138} ERROR - Error: Incompatible Parameters. You've provided both cycles and subset, which is not allowed. Please provide either cycles or subset separately, but not both.