Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug introduced in issues/36 where valid bboxes were raising an exception #149

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

skorper
Copy link
Contributor

@skorper skorper commented Aug 24, 2023

UAT for 1.15.0 found a bug where valid bboxes were raising an exception. There were two main issues:

  1. A check was added to ensure W <= E. This is not necessary, as that constraint would not hold if querying across the IDL.
  • Removed this validation step altogether
  1. There was a bug when checking if S <= N. The code was actually checking if S <= E, which is incorrect.
  • Fixed this bug

Did not update changelog, as this bug was introduced in #142 which has not yet been officially released.

Fixes #148

@skorper skorper merged commit 0119cfc into release/1.15.0 Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants