Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.15.0 UAT -- allow bbox that crosses the IDL #148

Open
skorper opened this issue Aug 24, 2023 · 0 comments
Open

1.15.0 UAT -- allow bbox that crosses the IDL #148

skorper opened this issue Aug 24, 2023 · 0 comments
Assignees

Comments

@skorper
Copy link
Contributor

skorper commented Aug 24, 2023

Issue found in 1.15.0 UAT: some bboxes are seeing validation errors:

  • -180,-60,-120,60
    • "ERROR - Error parsing "--bounds": S Latitude must be <= N Latitude"
  • 120,-60,-120,60
    • "ERROR - Error parsing "--bounds": W Longitude must be <= E Longitude"
  • -170,-20,-30,20
    • "Error parsing "--bounds": S Latitude must be <= N Latitude"

Some of these cross the IDL, which we do support so should not error out. Some of these do not cross the IDL so there is a bug in the validation code. We should probably limit the validation we're doing here -- so long as CMR/Harmony accept the bbox we should not complain. Maybe a check that -180<=Longitude<=10 and -90<Latitude<90 is sufficient for bbox validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant