Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix footprint and bbx always appears together issue #70

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

yenes56
Copy link
Contributor

@yenes56 yenes56 commented Dec 8, 2023

Github Issue: PODAAC-5857

Description

Making CMR validation error message more descriptive

Overview of work done

  • Fixed the issue so footprint and bbx do not always appear together while isoXmlSpatial is configured to footprint only
  • remove request.close() statement in CMRLambdaRestClient so the response could be pulled out and logged properly instead of always logging apache chunk read error due to the http channel was closed.
  • adding more parameters to Jsonschema2pojo plugin to generate proper pojo from ummg schema
  • Also , tested the issue we had with SWOT_L2_HR_RiverSP_1_0 before where isoXmlSpatial was set to bbox only and set to footprint only. After setting to footprint only, we always see both footprint and bbx. It is also fixed by this change

Overview of verification done

  • Unit test all cases no error
  • integration tested SWOT_L2_LR_SSH_2.0

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@@ -191,8 +191,6 @@ private void send(String url, HttpEntity entity) throws IOException {
} else {
logHttpResponse(response, HttpOp.SEND);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yenes56 What is the reason for needing to remove the request.releaseConnection() lines? This code has been present for a long time, why did it suddenly start causing the chunk error?

@skorper skorper merged commit 5dd54c9 into develop Jan 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants