Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated test notebook #78

Merged
merged 1 commit into from
Aug 21, 2023
Merged

updated test notebook #78

merged 1 commit into from
Aug 21, 2023

Conversation

sliu008
Copy link
Contributor

@sliu008 sliu008 commented Aug 16, 2023

Github Issue: #68

Description

Update notebook to pass tests for collections

Overview of work done

  • Update notebook to drop certain variables if exists
  • loop through groups to find the lon/lat
  • make notebook work with these collections
  • AQUARIUS_L2_SSS_V5
  • SMAP_RSS_L2_SSS_V4
  • CYGNSS_L2_CDR_V1.0
  • CYGNSS_L2_CDR_V1.1

Overview of verification done

  • tested the collections to make sure they pass the notebooks

Overview of integration done

Explain how this change was integration tested. Provide screenshots or logs if appropriate. An example of this would be a local Harmony deployment.

PR checklist:

  • Linted
  • Updated unit tests
  • Updated changelog
  • Integration testing

See Pull Request Review Checklist for pointers on reviewing this pull request

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@jamesfwood jamesfwood merged commit b99f0ce into develop Aug 21, 2023
3 of 4 checks passed
@jamesfwood jamesfwood deleted the feature/issue-68 branch August 21, 2023 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants