-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 117 improve name of output file #121
Feature/issue 117 improve name of output file #121
Conversation
…://github.com/podaac/concise into feature/issue-117-improve-name-of-output-file
Originally considered using the |
@danielfromearth Looks good. Thanks! I will merge it now ok? |
OK with me! |
Github Issue: #117
Description
Change the name of the output file, from:
f'{collection}_merged.nc4'
to
f'{first_url_name}_{datetimes[1].strftime('%Y%m%dT%H%M%SZ')}_{collection}_merged.nc4'
Overview of work done
The Harmony service adapter now grabs the URL of the first granule to be concatenated. The stem of this URL is then included in the name of the output file, along with the end time of the last granule. Had to unquote URL
%
symbols.Overview of verification done
All tests passed.
Overview of integration done
All tests passed.
PR checklist:
See Pull Request Review Checklist for pointers on reviewing this pull request