-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce min ballot duration in VotingToManageEmissionFunds contract #207
Introduce min ballot duration in VotingToManageEmissionFunds contract #207
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also review require
statements related to checking the _startTime
and _endTime
parameters in the VotingToManageEmissionFunds.createBallot
function. Since now we use the onlyValidTime
modifier inside the VotingTo._createBallot
internal function, those require
statements in VotingToManageEmissionFunds.createBallot
look redundant.
Let's also add
test/voting_to_manage_emission_funds_*.js for the VotingToManageEmissionFunds.finalize , vote , and init functions to cover the added code by tests.
|
I've checked the changes with |
#190