Add CELO chains support #446
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbaranov
force-pushed
the
vb-celo-support
branch
from
b7be33e
to
af6f510
Compare
prestwich
reviewed
Feb 12, 2021
| @@ -25,6 +25,11 @@ const { | |||
| TRANSACTION_TYPE_RETRY, | |||
| } = require('./enums') | |||
|
|
|||
| const ContractKit = require('@celo/contractkit') | |||
There was a problem hiding this comment.
Mixing commonjs require and es6 import here
There was a problem hiding this comment.
Thanks, James! I replaced requires with ES6 imports statements in 86a08d0 specifically for TransactionController. Though I am aware, there can be multiple places where mixing takes places in the code. I suppose other mixing occurrences can be processed in a separate refactoring PR(s).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding native support for CELO token transfers in CELO Mainnet, Alfajores/Baklava Testnets
Related changes in linked packages:
poanetwork/eth-net-props#41 - add basic Celo chains support (Mainnet, Alfajores/Baklava testnets)
poanetwork/eth-net-props#42 - add Celo Alfajores faucet
vbaranov/KeyringController@9f7897a - expose
getPrivateKeyFormethod to integrate with@celo/contractkitTransferring CELO via Nifty Wallet:
https://www.loom.com/share/62f163abcec342c7ac24333cb867ce14