Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: install more packages without panics #111

Merged
merged 2 commits into from
Sep 5, 2023

Conversation

KSXGitHub
Copy link
Contributor

This is a temporary fix to make benchmarking with pnpm possible. /cc @zkochan

Related to #108 and #100.

This is a temporary fix to make benchmarking with pnpm possible.

Related to #108
@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Benchmark Results

Linux

group                          main                                   pr
-----                          ----                                   --
tarball/download_dependency    1.01      8.1±0.24ms   537.1 KB/sec    1.00      8.0±0.13ms   541.3 KB/sec

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (46fd143) 84.61% compared to head (118338c) 84.61%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #111   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files          24       24           
  Lines        1365     1365           
=======================================
  Hits         1155     1155           
  Misses        210      210           
Files Changed Coverage Δ
crates/registry/src/package_distribution.rs 25.00% <ø> (ø)
crates/tarball/src/lib.rs 79.54% <ø> (ø)
crates/cli/src/package.rs 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

apparently blocking is a bad idea
@KSXGitHub
Copy link
Contributor Author

KSXGitHub commented Sep 5, 2023

spawn_blocking proves to be faster than spawn on a small package.json:

benchmark

But I was forced to change it back to spawn because it was extremely slow on a bigger package.json.

@anonrig anonrig merged commit 50022f6 into main Sep 5, 2023
17 checks passed
@anonrig anonrig deleted the emergency-fix-for-pnpm-benchmarking branch September 5, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants