V4 OneNote (notes) #2894
Merged
V4 OneNote (notes) #2894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding full Notes functionality Adding Tests Adding Documentation
|
Needs review please. Specifically how I handled the Combine<> within types.ts Using Omit<> and Pick<>, seems to remove the callable capability of the GraphQueryable objects. So I am using intersection types with the default response type such as _GraphCollection. Makes it callable and improves intellisense. Additionally, the docs are a bit confusing. Graph docs have functionality interspersed between different sections. I grouped them slightly differently. Hopefully it makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Category
What's in this Pull Request?
v4 implementation of OneNote