Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): migrate .eslintrc to eslint.config.js #2912

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Dec 18, 2024

Summary

  • mirgate legacy .eslintrc style to eslint.config.js

Check List

  • pnpm run prettier for formatting code and docs

Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
zustand-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 0:49am

Copy link

codesandbox-ci bot commented Dec 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

pkg-pr-new bot commented Dec 18, 2024

Open in Stackblitzdemo

npm i https://pkg.pr.new/zustand@2912

commit: 69bac4f

@dai-shi
Copy link
Member

dai-shi commented Dec 18, 2024

This is nice! I wasn't sure when all plugins are ready. They weren't when I last tried.
Are you sure all configs are migrated? No additions or removals?

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 18, 2024

This is nice! I wasn't sure when all plugins are ready. They weren't when I last tried. Are you sure all configs are migrated? No additions or removals?

@dai-shi i checked all plugins. if it's not i will keep my eyes on this, i migrated with no additions and removals

@dbritto-dev
Copy link
Collaborator

dbritto-dev commented Dec 18, 2024

@dai-shi @sukvvon IMHO, I prefer no config or simple config instead of complex config. In this case I'll keep the current config. We can use something else like OXC lint or Biome and simplify the config.

@dai-shi
Copy link
Member

dai-shi commented Dec 18, 2024

I'll keep the current config.

Do you mean to keep using eslint 8?

@sukvvon
Copy link
Contributor Author

sukvvon commented Dec 18, 2024

@dbritto-dev IMHO, Tools like oxc and biome could be considered as alternatives, but since they are still under development, it might be too early to use them. I believe eslint is still more practical at this point, with abundant references, widespread adoption, and ease of application. For now, as we are currently using eslint, it would be better to focus on supporting eslint and consider simplifying later.

@dbritto-dev
Copy link
Collaborator

dbritto-dev commented Dec 18, 2024

I wouldn't put much effort on eslint is pretty slow and now are better options, apart from that biome is ready for production. This change just make it more complex to maintain and add another dependency to make it work I do not think that worth it.

@dai-shi
Copy link
Member

dai-shi commented Dec 18, 2024

Our ecosystem still depends on eslint plugins. Maybe, eslint-plugin-react-compiler is one of the biggest hurdles. Let's stick with eslint.

@dbritto-dev
Copy link
Collaborator

@dai-shi do we need this change to support react-compiler plugin?

@dbritto-dev
Copy link
Collaborator

I'll keep the current config.

Do you mean to keep using eslint 8?

yeah

@dai-shi
Copy link
Member

dai-shi commented Dec 18, 2024

react-compiler is already included. eslint 8 will no longer be supported. This change is what I wanted to do when eslint 9 was released, but at that point something wasn't ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants