-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): migrate .eslintrc to eslint.config.js #2912
base: main
Are you sure you want to change the base?
chore(eslint): migrate .eslintrc to eslint.config.js #2912
Conversation
… eslint.config.js
…ate script for eslint.config.js
…js to eslint.config.js
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
commit: |
This is nice! I wasn't sure when all plugins are ready. They weren't when I last tried. |
@dai-shi i checked all plugins. if it's not i will keep my eyes on this, i migrated with no additions and removals |
Do you mean to keep using eslint 8? |
@dbritto-dev IMHO, Tools like |
I wouldn't put much effort on eslint is pretty slow and now are better options, apart from that biome is ready for production. This change just make it more complex to maintain and add another dependency to make it work I do not think that worth it. |
Our ecosystem still depends on eslint plugins. Maybe, eslint-plugin-react-compiler is one of the biggest hurdles. Let's stick with eslint. |
@dai-shi do we need this change to support |
yeah |
react-compiler is already included. eslint 8 will no longer be supported. This change is what I wanted to do when eslint 9 was released, but at that point something wasn't ready. |
Summary
.eslintrc
style toeslint.config.js
Check List
pnpm run prettier
for formatting code and docs