fix(transform): Updates to support glTF Transform v4 #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
force-pushed
the
feat/weld-default
branch
from
df0b876 to
c008a8b
Compare
donmccurdy
changed the title
donmccurdy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In glTF Transform v4, the
weld()function no longer takes a tolerance option. It is now always lossless, and runs (much) faster than in v3. I think it would make sense now to enableweld()by default, rather than putting it behind thesimplifyoption.Aside: I'm having trouble withyarn build(seems unrelated?), and so haven't been able to test this locally. The changes look safe enough, but may need someone else to do a quick test, or I'll look further into the build issue when I have a chance.Also, it looks like we may need to put
@gltf-transform/*inpackage.json#resolutions. On themasterbranch, running the CLI locally fails, because multiple versions (4.0.4 + 4.0.8) of@gltf-transform/coreare loaded, and things likeinstanceofchecks will fail. Rather than usingresolutions, allowing a semver range for each dependency should also be fine. I don't think this part is unique to glTF Transform v4.