Don't throw away thread object

plugdata-team · Aug 31, 2023 · a2e7444 · a2e7444
1 parent 3f67335
commit a2e7444
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/Source/Objects/ofxOfeliaMessageManager.h b/Source/Objects/ofxOfeliaMessageManager.h
@@ -34,7 +34,7 @@ class TimerThread
         if (!running)
         {
             running = true;
-            std::thread([this, intervalMillis]() {
+            timerThread = std::thread([this, intervalMillis]() {
                 while (running)
                 {
                     auto start = std::chrono::high_resolution_clock::now();
@@ -47,19 +47,21 @@ class TimerThread
                     if (sleepTime > std::chrono::milliseconds::zero())
                         std::this_thread::sleep_for(sleepTime);
                 }
-            }).detach();
+            });
         }
     }
 
     void stop()
     {
         running = false;
+        timerThread.join();
     }
 
     virtual void timerCallback() = 0;
 
 private:
-    bool running;
+    std::thread timerThread;
+    std::atomic<bool> running;
 };