[inferno-vc] Made fetchObjectClosureHashes return the root scriptId and added logging to cached client and server #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t because it is part of the closure
…losureHashes requests with args
brent80
pushed a commit
that referenced
this pull request
Oct 12, 2024
…nd added logging to cached client and server (take 2) (#139) Second take of #137. This version: - removes emojis from log messages so `LANG` env var doesn't need to be set to a UTF8 compatible one - Changes the directory where closure hashes are cached to `deps-v2` so we don't read previously cached deps without the root scriptId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made fetchObjectClosureHashes return the root scriptId because it belongs to the closure and so it is coherent with fetchObjectClosure. This makes the cached client take a lock on the requested scriptHash too when fetching the object which it wasn't doing before.
Also added logging to cached client to see hits/missed and to server to see which scriptIds are being used to call fetchObjects and fetchObjectClosureHashes