Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent swallowing of ValueError in core.py #3888

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

haydenflinner
Copy link

Traceback that this leads to:

File .../python3.9/site-packages/plotly/express/_core.py:2226, in make_figure(args, constructor, trace_patch, layout_patch)
   2223 if args.get("marginal_y") is not None:
   2224     ncols += 1
-> 2226 fig = init_figure(
   2227     args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels
   2228 )
   2230 # Position traces in subplots
   2231 for frame in frame_list:

File .../python3.9/site-packages/plotly/express/_core.py:2373, in init_figure(args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels)
   2370     _spacing_error_translator(e, "Vertical", "facet_row_spacing")
   2372 # Remove explicit font size of row/col titles so template can take over
-> 2373 for annot in fig.layout.annotations:
   2374     annot.update(font=None)
   2376 return fig

UnboundLocalError: local variable 'fig' referenced before assignment

Traceback that this leads to:
```
File .../python3.9/site-packages/plotly/express/_core.py:2226, in make_figure(args, constructor, trace_patch, layout_patch)
   2223 if args.get("marginal_y") is not None:
   2224     ncols += 1
-> 2226 fig = init_figure(
   2227     args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels
   2228 )
   2230 # Position traces in subplots
   2231 for frame in frame_list:

File .../python3.9/site-packages/plotly/express/_core.py:2373, in init_figure(args, subplot_type, frame_list, nrows, ncols, col_labels, row_labels)
   2370     _spacing_error_translator(e, "Vertical", "facet_row_spacing")
   2372 # Remove explicit font size of row/col titles so template can take over
-> 2373 for annot in fig.layout.annotations:
   2374     annot.update(font=None)
   2376 return fig

UnboundLocalError: local variable 'fig' referenced before assignment
```
@gvwilson gvwilson added feature something new P2 considered for next cycle community community contribution labels Aug 12, 2024
Copy link
Member

@ndrezn ndrezn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community community contribution feature something new P2 considered for next cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants