-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
react to config changes #6395
base: master
Are you sure you want to change the base?
react to config changes #6395
Conversation
Nice! Maybe then just a test like this one but for cartesian?
|
@alexcjohnson I don't recall what |
So looks like on CI it's ignored, but it marks tests that need to run so the noCI tests succeed. Quite possibly obsolete by now, you could try running just And good call, I somehow hadn't noticed the cartesian test right above that 😅 But that test was already passing, right? So what can we add to that test that would have broken before this change but now works correctly? |
Fixes #6394.
@plotly/plotly_js