Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Plotly.js v3 docs #325

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from
Draft

WIP: Plotly.js v3 docs #325

wants to merge 24 commits into from

Conversation

LiamConnors
Copy link
Member

@LiamConnors LiamConnors commented Oct 9, 2024

Work in progress. Adding to it as changes are merged in Plotly.js repo

cc @emilykl @archmoj

@LiamConnors LiamConnors changed the title Plotly.js v3 WIP: Plotly.js v3 Oct 9, 2024
@LiamConnors LiamConnors changed the title WIP: Plotly.js v3 WIP: Plotly.js v3 docs Oct 10, 2024
@archmoj archmoj marked this pull request as ready for review October 24, 2024 20:13
@LiamConnors LiamConnors marked this pull request as draft October 24, 2024 20:17
@LiamConnors
Copy link
Member Author

@archmoj
Copy link

archmoj commented Oct 24, 2024

@LiamConnors it looks like those mock used to have transforms. Now that transforms are removed the new image look correct.

@archmoj
Copy link

archmoj commented Oct 25, 2024

Is ref_names.txt is auto generated? Or should we manually remove transforms?

@LiamConnors
Copy link
Member Author

Is ref_names.txt is auto generated? Or should we manually remove transforms?

Thanks @archmoj. I think it's automatically generated but can't say for certain. We can wait until we update this repo with the new Plotly.js release and regenerate. If it's still there, we can take it out at that stage


### Transforms

Transforms have been removed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some explanation of what to do instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is there is no replacement for this.
cc @archmoj. Do you know if there's anything we can recommend in JS?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants