Fix several broken links and console errors #261
+22
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To solve plotly/plotly.js#6706
The issue is about a broken link. I used https://www.drlinkcheck.com/ to find all the broken links in https://plotly.com/javascript/.
It only scanned the first 2000 links without paying.
This PR fixes multiple issues
'more controls' button doesn't need to exist as all control options are already displayed (there are 5). Subplots has 6 and we see the button
inside a code block throws a console warning about un-escaped HTML - but if we escape it the link won't work. The link is v hidden anyway, imo it can be removed
Fastly's logo is no longer at that URL and I couldn't find where it is
main.css corrected a a typo. There is still an unclosed
{(line 9094) but closing it messes up the page CSS... Not obvious how to fix thatswapped highlightBlock for highlightElement, to fix console warning. https://highlightjs.readthedocs.io/en/latest/api.html