Deprecation removals #3078
Open
Deprecation removals #3078
+297
−903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T4rk1n
requested review from
alexcjohnson,
ndrezn,
gvwilson and
emilykl
as code owners
|
Ready for review! |
|
Woohoo!! 🙌 It looks like |
|
@T4rk1n What's the backstory regarding |
emilykl
reviewed
Nov 19, 2024
| @@ -342,7 +344,7 @@ def register_callback( | |||
| flat_state, | |||
| inputs_state_indices, | |||
| prevent_initial_call, | |||
| long=long, | |||
There was a problem hiding this comment.
@T4rk1n What about this argument called long= here, is there a reason it needs to stay?
The button was made for DE4 but doesn't work with DE5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
app.run_serverdcc.LogoutButtonlongtobackground