Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes: Insert a Mermaid diagram in docs/contributing/core/package-dependencies.md #1715

Draft
wants to merge 10 commits into
base: 6.0
Choose a base branch
from

Conversation

jensens
Copy link
Member

@jensens jensens commented Sep 26, 2024

Fixes #1683


📚 Documentation preview 📚: https://plone6--1715.org.readthedocs.build/

@stevepiercy
Copy link
Contributor

Unfortunately we cannot support Mermaid diagrams in plone-sphinx-theme. See:

I would love to support mermaid, but until that issue is resolved, I can't merge this PR. We can keep it open until then.

@jensens
Copy link
Member Author

jensens commented Sep 26, 2024

Unfortunately we cannot support Mermaid diagrams in plone-sphinx-theme

Yay.

@stevepiercy
Copy link
Contributor

@jensens let's revisit this. See #1777.

@stevepiercy
Copy link
Contributor

@jensens I went ahead and did a review by directly editing the file. I approve. Is this ready to merge? It's marked as Draft.

Check it out: https://plone6--1715.org.readthedocs.build/contributing/core/package-dependencies.html

@stevepiercy
Copy link
Contributor

@jensens I made a couple of enhancements to the Mermaid diagrams. Now they have alt, caption, and zoom attributes.

I don't understand the second diagram, but it's pretty.

@stevepiercy
Copy link
Contributor

@jensens would you please take a look at the pull request preview at https://plone6--1715.org.readthedocs.build/conceptual-guides/package-dependencies.html and let me know if this is ready to merge or you want to make any changes? I moved it into the Conceptual Guides from contributing to Plone core, since this is not really a how-to guide. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

Insert a Mermaid diagram in conceptual-guides/package-dependencies.md
2 participants