Provide the ability to get remote static public key #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's the application's responsibility to determine whether the remote party's static public key is acceptable, as the security consideration section stated in The Noise Protocol Framework. However, the current implementation does not provide the opportunity for application to examine the remote party's static public key.
Once the handshake process is done, the
HandshakeStateobject is deleted, and this is also the recommended behavior. Thus, in this PR, I try to reuse thekeypairsfield inNoiseProtocolobject to record the keypairs which will be encountered during the handshake process, and provide aget_public_bytesinterface to retrieve these keys.The test for this new API is also provided in this PR.