Log warnings when internal queue is full #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…en a message cannot be delivered immediately to a queue
…arnings to the logs for every time it fails.
MortenKaae
reviewed
Jul 14, 2021
motorway/messages.py
Outdated
|
|
||
| queue.send_string( | ||
| self.as_json(), | ||
| flags=zmq.backend.cython.constants.NOBLOCK # Raise and exception if the queue is full. |
There was a problem hiding this comment.
Typo in comment "and" -> "an"
guy881
reviewed
Jul 15, 2021
motorway/mixins.py
Outdated
| message_retries = 0 | ||
| while True: | ||
| try: | ||
| message.send( |
There was a problem hiding this comment.
Don't think we're doing 80 chars here, so no point to do a new line here, I guess?
guy881
approved these changes
Jul 15, 2021
|
@KristianOellegaard I would prefer if you will also take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch from using a blocking call to add messages to the queue, to a using a call that will raise an exception if the message cannot be delivered instantaneously. this gives us the option to log warnings when a queue is full