-
Notifications
You must be signed in to change notification settings - Fork 682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check handle multiple value #1023
Open
pengzhang
wants to merge
1,399
commits into
playframework:master
Choose a base branch
from
pengzhang:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[#1901] feat(lib): update to slf4j-log4j12 1.7.10
Conflicts: samples-and-tests/just-test-cases/conf/application.conf
…nstead of the st poster on the forum
… JSON response - added missing import
…a specific test category (unit, functional, selenium)
[playframework#1344] Fixed OAuth2 lib not finding access_token inside JSON response
…to define a custom path
[#1924] Sane c3p0 logging
[#1916] Get Java version from application.conf
…rMaster [#1937] fix(router): make some improvement in router
….1.35 Conflicts: framework/dependencies.yml
that just duplicates class name
# Conflicts: # framework/src/play/db/DB.java
…ange of htmlUnit * [playframework#986] chore(lib): update htmlunit from 2.19 to 2.23
…e as a key message * [playframework#996] fix(messages): ensure default is null before using it # Conflicts: # framework/src/play/mvc/Scope.java
# Conflicts: # documentation/manual/home.textile
…gument e.g. #{form '/customer/12' ....
…ately from controller execution time.
…when compiling a temaplate with a non GroovyInlineTag ** revert modif on GroovyTemplateCompiler.java don in 765dec2
so we can run all unit-tests in IDE by one click
it seems that it was broken. That's why http://localhost:9000/@db didn't show tables on the left
…patch [#2066] fix-open-file-on-500-error-pages-for-modules
…ed configLastModified on application start
…static args in routes # Conflicts: # framework/src/play/mvc/Router.java
…atch [#2066] avoid NPE in regex matcher
@pengzhang Thank you for the pull request! Also, can we refactor code a little bit? Namely, name of variable private static void check(Check check) throws Throwable {
boolean hasProfile = false;
for (String profile : check.value()) {
hasProfile = hasProfile || (Boolean)Security.invoke("check", profile);
}
if (!hasProfile) {
Security.invoke("onCheckFailed", "");
}
} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Secure module Check Annotation handle multiple value