Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #700 - Safe Json.parse alternatives #987

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

cchantep
Copy link
Member

Pull Request Checklist

  • Have you read through the contributor guidelines?
  • Have you squashed your commits?
  • Have you added copyright headers to new files?
  • Have you updated the documentation?
  • Have you added tests for any changed functionality?

Fixes

Fixes #700

@mkurz
Copy link
Member

mkurz commented Mar 12, 2024

@cchantep Binary Compatibility checks fail, so probably this has to wait for play-json 3.1.0 (?)

mimaBinaryIssueFilters ++= Seq(
),
mimaBinaryIssueFilters ++= {
val missingMethodInOld: ProblemFilter = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding new feature doesn't break backward compat

@cchantep cchantep merged commit d79f375 into playframework:main Aug 8, 2024
17 checks passed
@cchantep cchantep deleted the task/700-tryparse branch August 8, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a JSON parsing API that returns Try or similar type instead of throwing exception
2 participants