Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MessageRequest and IMessageCodec #3997

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Refactor MessageRequest and IMessageCodec #3997

merged 3 commits into from
Nov 25, 2024

Conversation

greymistcube
Copy link
Contributor

@greymistcube greymistcube commented Nov 25, 2024 •
edited
Loading

This serves several purposes:

  • Makes IMessageCodec interface more symmetric.
  • Postpones encoding of Message to NetMQMessage until it is necesary.
  • Allows message type to be observable without unnecessarily parsing raw bytes

@greymistcube greymistcube marked this pull request as ready for review November 25, 2024 08:37
@greymistcube greymistcube changed the title Refactor MessageRequest Refactor MessageRequest and IMessageCodec Nov 25, 2024
@greymistcube greymistcube merged commit 71b6280 into planetarium:main Nov 25, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limebell limebell limebell approved these changes

Assignees

@greymistcube greymistcube

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@greymistcube @limebell