Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor GasTracer #3974

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Refactor GasTracer #3974

merged 3 commits into from
Oct 28, 2024

Conversation

s2quake
Copy link
Contributor

@s2quake s2quake commented Oct 25, 2024 •
edited
Loading

Changes

  • Added Added CancelTrace method to GasTracer.

@s2quake s2quake force-pushed the refactor/gas-tracer branch from 680df7e to efd4aa4 Compare October 25, 2024 07:08
@s2quake s2quake force-pushed the refactor/gas-tracer branch from efd4aa4 to 7b8b6ad Compare October 25, 2024 07:11
@s2quake s2quake marked this pull request as ready for review October 25, 2024 07:22
riemannulus
riemannulus reviewed Oct 25, 2024
View reviewed changes
src/Libplanet.Action/ActionEvaluator.cs Outdated Show resolved Hide resolved
src/Libplanet.Action/GasMeter.cs Outdated Show resolved Hide resolved
@s2quake s2quake marked this pull request as draft October 25, 2024 10:54
@s2quake s2quake force-pushed the refactor/gas-tracer branch 2 times, most recently from 129b0cb to 7d041d1 Compare October 25, 2024 12:34
@s2quake s2quake marked this pull request as ready for review October 25, 2024 12:38
@s2quake s2quake requested a review from riemannulus October 25, 2024 12:51
riemannulus
riemannulus previously approved these changes Oct 26, 2024
View reviewed changes
Copy link
Member

@riemannulus riemannulus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But, Could you make the test about GasTracer.IsTraceCancelled?

@s2quake s2quake force-pushed the refactor/gas-tracer branch 2 times, most recently from 336d46c to 07a95f0 Compare October 26, 2024 11:00
@s2quake s2quake requested a review from riemannulus October 26, 2024 11:23
@s2quake
Copy link
Contributor Author

s2quake commented Oct 26, 2024

LGTM! But, Could you make the test about GasTracer.IsTraceCancelled?

Test code for GasTracer.IsTraceCancelled has been committed. 6d4da2a

@s2quake s2quake force-pushed the refactor/gas-tracer branch from 07a95f0 to f2f8525 Compare October 28, 2024 00:28
@s2quake s2quake requested a review from riemannulus October 28, 2024 00:44
@s2quake s2quake merged commit c1a1c5e into main Oct 28, 2024
30 checks passed
@s2quake s2quake deleted the refactor/gas-tracer branch October 28, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@limebell limebell Awaiting requested review from limebell

@OnedgeLee OnedgeLee Awaiting requested review from OnedgeLee

@greymistcube greymistcube Awaiting requested review from greymistcube

@riemannulus riemannulus Awaiting requested review from riemannulus

Assignees

@s2quake s2quake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@s2quake @riemannulus